-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add temperature plate model constant age to oceanic plate models #344
Conversation
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
==========================================
+ Coverage 98.84% 98.85% +0.01%
==========================================
Files 76 77 +1
Lines 4428 4472 +44
==========================================
+ Hits 4377 4421 +44
Misses 51 51
Continue to review full report at Codecov.
|
|
6571347
to
161acde
Compare
Thanks for making this into a pull request. It looks good to me. I had to think a bit about issue #351, but since it is an issue with all the oceanic temperature models, I don't think it should hold back this pull request. Can you add a test and a line in the changelog? Let me know if you need help with either. |
Yes, I would like to ask these questions. |
a. There are different kind of test, but I think that that is indeed the best kind for this plugin. I hope this answers your questions, otherwise let me know :) |
161acde
to
93ed23e
Compare
Hi @MFraters |
Hi |
93ed23e
to
baf6681
Compare
Great, thanks for the pull request and making the changes! |
I add a "plate model constant age" plugin under "oceanic plate". This takes a constant age of the plate and assign a temperature field using the plate model.